Skip to content

[DUBBO-3137]: move MetadataReportConstants back into metata-report-api module#4049

Merged
CrazyHZM merged 1 commit intoapache:masterfrom
beiwei30:issue3137
May 14, 2019
Merged

[DUBBO-3137]: move MetadataReportConstants back into metata-report-api module#4049
CrazyHZM merged 1 commit intoapache:masterfrom
beiwei30:issue3137

Conversation

@beiwei30
Copy link
Copy Markdown
Member

@beiwei30 beiwei30 commented May 14, 2019

What is the purpose of the change

issue #3137 : move MetadataReportConstants back into metata-report-api module

Brief changelog

XXXXX

Verifying this change

XXXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@beiwei30 beiwei30 requested a review from CrazyHZM May 14, 2019 02:09
@ralf0131
Copy link
Copy Markdown
Contributor

ralf0131 commented May 14, 2019

Could you please hold this until #4025 is merged?

CrazyHZM
CrazyHZM approved these changes May 14, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@CrazyHZM CrazyHZM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link
Copy Markdown

codecov-io commented May 14, 2019

Codecov Report

Merging #4049 into master will increase coverage by 0.01%.
The diff coverage is 42.85%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #4049      +/-   ##
============================================
+ Coverage     63.12%   63.14%   +0.01%     
- Complexity      565      566       +1     
============================================
  Files           753      753              
  Lines         32417    32414       -3     
  Branches       5145     5145              
============================================
+ Hits          20464    20467       +3     
+ Misses         9598     9593       -5     
+ Partials       2355     2354       -1
Impacted Files Coverage Δ Complexity Δ
...a/org/apache/dubbo/metadata/support/Constants.java 100% <ø> (ø) 0 <0> (?)
...c/main/java/org/apache/dubbo/common/Constants.java 0% <ø> (-75%) 0 <0> (ø)
...bo/metadata/integration/MetadataReportService.java 78.04% <0%> (ø) 0 <0> (ø) ⬇️
...dubbo/metadata/support/AbstractMetadataReport.java 71.09% <75%> (ø) 0 <0> (ø) ⬇️
.../exchange/support/header/HeaderExchangeServer.java 66.98% <0%> (-0.95%) 0% <0%> (ø)
...g/apache/dubbo/registry/consul/ConsulRegistry.java 59.6% <0%> (-0.67%) 27% <0%> (ø)
...he/dubbo/registry/multicast/MulticastRegistry.java 69.23% <0%> (-0.46%) 0% <0%> (ø)
...dubbo/rpc/protocol/dubbo/CallbackServiceCodec.java 80.88% <0%> (+0.73%) 0% <0%> (ø) ⬇️
...pache/dubbo/remoting/transport/AbstractServer.java 48.95% <0%> (+1.04%) 0% <0%> (ø) ⬇️
...che/dubbo/remoting/transport/mina/MinaChannel.java 55.26% <0%> (+1.31%) 18% <0%> (+1%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 175eab1...787a1af. Read the comment docs.

@CrazyHZM CrazyHZM merged commit d24d614 into apache:master May 14, 2019
@beiwei30 beiwei30 deleted the issue3137 branch May 14, 2019 03:24
@dubbo-bot dubbo-bot mentioned this pull request May 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CrazyHZM CrazyHZM CrazyHZM approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@beiwei30 @ralf0131 @codecov-io @CrazyHZM
⚡